-
Notifications
You must be signed in to change notification settings - Fork 77
boot: zephyr: boards: Assign boot_partition to code-patition #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: upstream-sync
Are you sure you want to change the base?
boot: zephyr: boards: Assign boot_partition to code-patition #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just completely wrong, as I said before, you need to set this at the zephyr level, setting it here builds a bootloader which is setup for this and no application will work because the applications are not using the same partition layout which makes it useless
So, this means we need to have this PR approved: zephyrproject-rtos/zephyr#90758 and as you know this PR is being blocked by objections. That's why I closed the ticket and started to think about other ways to approach this. Can you suggest how to proceed with getting the SysBuild partitions at Zephyr level? |
If it is not feasible to get SysBuild partitions support at Zephyr boards level and mcuboot level, maybe we can add the support in the samples level: zephyrproject-rtos/zephyr#91386 Please take a look when you have time and let me know what you think. Thanks! |
You can add a board variant that has the partition layout, I don't see why that would be rejected, e.g. |
Okay, thank you! Will use the board variant for the partition layout! |
Working on
Board name to use MCUboot without WiFi: Please advise if the above sounds okay. Thanks! |
Query for @soburi but OK to me |
Include the 2M SysBuild partitions using board variants: - rpi_pico/rp2040/mcuboot - rpi_pico/rp2040/w/mcuboot Assign boot_partition to code_paritition. Signed-off-by: John Lin <john.lin@beechwoods.com>
Conceptually, mcuboot is a software configuration rather than a hardware characteristic, |
bd2fbff
to
bac82a7
Compare
PR using variants: |
Any other alternatives to add |
The fundamental problem is that there is no way to configure boards when sysbuild-ing. About for this PR, the overlay to be applied to this mcuboot should be ok as below.
|
Do you have more info for |
This is an example of how we need to add functionality like this. As a temporary workaround, defining overlays in each app should be fine. In other words, the problem is that there is no mechanism to apply settings in conjunction with sysbuild, so I think it would be best to raise that issue first. |
Okay, got it! In the mean time, should we go ahead and use the variant
method for now?
…On Tue, Jun 17, 2025, 9:39 PM TOKITA Hiroshi ***@***.***> wrote:
*soburi* left a comment (zephyrproject-rtos/mcuboot#129)
<#129 (comment)>
Do you have more info for sysbuild.overlay? Cause I tried that and it's
not working!
This is an example of how we need to add functionality like this.
Since there is no such feature, we need to propose adding it to the build
system and then implement it.
—
Reply to this email directly, view it on GitHub
<#129 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATRRPBFYRU67R3LPPYBEEPL3EDUOZAVCNFSM6AAAAAB65SGLBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBSGY2DOMJWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The point in board variants is for exactly that, to provide alternative software-defined parts (note: not needing hardware changes). Most other boards already have an MCUboot-style partition layout so they do not offer one. Having files like that in MCUboot is not useful because apps will absolutely not work with it and would need files duplicated in them, and we're not about to duplicate those files in lots of samples in zephyr so specific samples can build on those boards, with a board variant then no files are needed in any samples or any other repos and it doesn't impact any existing users, but users wanting to build for MCUboot can then do so. From https://docs.zephyrproject.org/latest/glossary.html#term-variant
Good example is this board: https://github.com/zephyrproject-rtos/zephyr/tree/main/boards/adafruit/feather_nrf52840 it has the normal board and a uf2 variant, normal one includes this partition layout: https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/vendor/nordic/nrf52840_partition.dtsi which is MCUboot compatible, the uf2 variant has this partition layout: https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/vendor/nordic/nrf52840_partition_uf2_sdv6.dtsi which is not MCUboot compatible, and users can pick which one to build for The alternative is no support is added and users do it with a board extension out of tree |
Thank you for your clarification. > @nordicjm I was misunderstood at this point.
Referring to the policy, there is no problem with this PR. @jlbwoods |
Also, before merging this PR, we need approval for this |
Include the 2M SysBuild partitions using board variants: